Skip to content

Minor diag fixes in TypedTreePickle #18469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Minor diag fixes in TypedTreePickle #18469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/Compiler/TypedTree/TypedTreePickle.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,14 @@ type NodeOutTable<'Data, 'Node> =
Table = Table<_>.Create nm
}

// Small glossary for future generations:
// o... - output
// i... - input
// os - output stream
// is - input stream
// tab - table
// osgn - output stream graph nodes

[<NoEquality; NoComparison>]
type WriterState =
{
Expand Down Expand Up @@ -1937,7 +1945,7 @@ let u_tcref st =
match tag with
| 0 -> u_local_item_ref st.ientities st |> ERefLocal
| 1 -> u_nleref st |> ERefNonLocal
| _ -> ufailwith st "u_item_ref"
| _ -> ufailwith st "u_tcref"

let u_ucref st =
let a, b = u_tup2 u_tcref u_string st
Expand Down Expand Up @@ -2027,7 +2035,7 @@ let u_vref st =
match tag with
| 0 -> u_local_item_ref st.ivals st |> VRefLocal
| 1 -> u_nonlocal_val_ref st |> VRefNonLocal
| _ -> ufailwith st "u_item_ref"
| _ -> ufailwith st "u_vref"

let u_vrefs = u_list u_vref

Expand Down Expand Up @@ -3206,7 +3214,7 @@ and u_parentref st =
match tag with
| 0 -> ParentNone
| 1 -> u_tcref st |> Parent
| _ -> ufailwith st "u_attribkind"
| _ -> ufailwith st "u_parentref"

and u_attribkind st =
let tag = u_byte st
Expand Down Expand Up @@ -3496,7 +3504,7 @@ and u_lval_op_kind st =
| 1 -> LByrefGet
| 2 -> LSet
| 3 -> LByrefSet
| _ -> ufailwith st "uval_op_kind"
| _ -> ufailwith st "ulval_op_kind"

and p_op x st =
match x with
Expand Down
Loading