Skip to content

Make unused bindings an error #18421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 31, 2025
Merged

Make unused bindings an error #18421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ba1dfbd
reenable unused binding detection
T-Gro Mar 27, 2025
d0ca444
fantomas
T-Gro Mar 27, 2025
2b9ad2f
vsintegration/tests - ignored unused bindings in selected test projects
T-Gro Mar 27, 2025
0ab310c
Update FSharpBuild.Directory.Build.props
T-Gro Mar 27, 2025
81b4d0a
Merge branch 'main' into re-enable-unused-bindings-warning
T-Gro Mar 27, 2025
b345b6b
lexyac
T-Gro Mar 27, 2025
36f9d56
satisfy build
T-Gro Mar 27, 2025
cfa965e
one more ignore
T-Gro Mar 28, 2025
da0b7ed
Update FSharp.Compiler.Service.Tests.fsproj
T-Gro Mar 28, 2025
d86783b
VS FSI has too many unused bindings...
T-Gro Mar 31, 2025
6ba0ec3
another
T-Gro Mar 31, 2025
b989d60
and salsa..
T-Gro Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FSharpBuild.Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<ProtoOutputPath>$(ArtifactsDir)\Bootstrap</ProtoOutputPath>
<ValueTupleImplicitPackageVersion>4.4.0</ValueTupleImplicitPackageVersion>
<WarnOn>$(WarnOn);1182</WarnOn>
<WarningsAsErrors>0025;$(WarningsAsErrors)</WarningsAsErrors>
<WarningsAsErrors>1182;0025;$(WarningsAsErrors)</WarningsAsErrors>
<OtherFlags>$(OtherFlags) --nowarn:3384</OtherFlags>
<OtherFlags>$(OtherFlags) --times --nowarn:75</OtherFlags>
<OtherFlags Condition="$(AdditionalFscCmdFlags) != ''">$(OtherFlags) $(AdditionalFscCmdFlags)</OtherFlags>
Expand Down
3 changes: 2 additions & 1 deletion buildtools/fslex/fslex.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<TargetFramework>$(FSharpNetCoreProductTargetFramework)</TargetFramework>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<RollForward Condition="'$(BUILDING_USING_DOTNET)' == 'true'">LatestMajor</RollForward>
<NoWarn>$(NoWarn);64;1182;1204</NoWarn> <!--Temporary fix for sourcebuild -->
<NoWarn>$(NoWarn);64;1204;1182</NoWarn> <!--Temporary fix for sourcebuild -->
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
</PropertyGroup>

<PropertyGroup>
Expand Down
3 changes: 2 additions & 1 deletion buildtools/fsyacc/fsyacc.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
<TargetFramework>$(FSharpNetCoreProductTargetFramework)</TargetFramework>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<RollForward Condition="'$(BUILDING_USING_DOTNET)' == 'true'">LatestMajor</RollForward>
<NoWarn>$(NoWarn);64;1182;1204</NoWarn> <!--Temporary fix for sourcebuild -->
<NoWarn>$(NoWarn);64;1204;1182</NoWarn> <!--Temporary fix for sourcebuild -->
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
</PropertyGroup>

<PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions tests/FSharp.Compiler.Service.Tests/EditorTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ open FSharp.Compiler.Symbols
open FSharp.Compiler.Text
open FSharp.Compiler.Tokenization

#nowarn "1182" // Unused bindings when ignored parsed results etc.

let stringMethods =
[
"Chars"; "Clone"; "CompareTo"; "Contains"; "CopyTo"; "EndsWith";
Expand Down
1 change: 1 addition & 0 deletions tests/FSharp.Compiler.Service.Tests/FSharp.Compiler.Service.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
<TargetFrameworks Condition="'$(OS)' == 'Unix' or '$(BUILDING_USING_DOTNET)' == 'true'">$(FSharpNetCoreProductTargetFramework)</TargetFrameworks>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>$(NoWarn);1182</NoWarn> <!-- suppress warning for unused values in FSharp.Compiler.Service.Tests tests, very often checker results are needed, but not used -->
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<UnitTestType>xunit</UnitTestType>
</PropertyGroup>
Expand Down
2 changes: 2 additions & 0 deletions tests/FSharp.Compiler.Service.Tests/MultiProjectAnalysisTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ open FSharp.Compiler.Text
open FSharp.Compiler.Service.Tests.Common
open TestFramework

#nowarn "1182" // Unused bindings when ignored parsed results etc.

let toIList (x: _ array) = x :> IList<_>
let numProjectsForStressTest = 100
let internal checker = FSharpChecker.Create(projectCacheSize=numProjectsForStressTest + 10, useTransparentCompiler = CompilerAssertHelpers.UseTransparentCompiler)
Expand Down
2 changes: 1 addition & 1 deletion tests/FSharp.Core.UnitTests/FSharp.Core.UnitTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<PreRelease>true</PreRelease>
<LangVersion>preview</LangVersion>
<NoWarn>$(NoWarn);1182</NoWarn> <!-- suppress warning for unused values in FSharp.Core tests, there are way too many of edge case scenarios tested -->

<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<UnitTestType>xunit</UnitTestType>
<IsTestProject>true</IsTestProject>
Expand Down
2 changes: 1 addition & 1 deletion vsintegration/src/FSharp.VS.FSI/FSharp.VS.FSI.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<OutputType>Library</OutputType>
<NoWarn>$(NoWarn);47;75;1182</NoWarn><!-- 1182 - unused bindings, too many of them here -->
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<OtherFlags>$(OtherFlags) --subsystemversion:6.00</OtherFlags>
<OtherFlags>$(OtherFlags) --subsystemversion:6.00 --warnaserror-:1182</OtherFlags>
<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
</PropertyGroup>

Expand Down
6 changes: 3 additions & 3 deletions vsintegration/src/FSharp.VS.FSI/sessions.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ type internal EventWrapper() =

/// Run function application return Some (f x) or None if execution exceeds timeout (in ms).
/// Exceptions raised by f x are caught and reported in DEBUG mode.
let timeoutApp descr timeoutMS (f : 'a -> 'b) (arg:'a) =
let timeoutApp _descr timeoutMS (f : 'a -> 'b) (arg:'a) =
use ev = new EventWrapper()
let mutable r = None
ThreadPool.QueueUserWorkItem(fun _ ->
Expand All @@ -57,7 +57,7 @@ let timeoutApp descr timeoutMS (f : 'a -> 'b) (arg:'a) =
"fsi.exe starts the remoting server at the end of it's initialisation sequence.\n" +
"The initialisation sequence takes an observable time (e.g. 2 seconds).\n" +
"Remoting exceptions are to be expected on interrupt/intellisense calls made before that point.\n" +
"Context: " + descr + "\n" +
"Context: " + _descr + "\n" +
"Exception: " + e.ToString()) |> ignore
#endif
None
Expand Down Expand Up @@ -285,7 +285,7 @@ let fsiStartInfo channelName sourceFile =
procInfo


let nonNull = function null -> false | (s:string) -> true
let nonNull = function null -> false | (_:string) -> true

/// Represents an active F# Interactive process to which Visual Studio is connected via stdin/stdout/stderr and a remoting channel
type FsiSession(sourceFile) =
Expand Down
2 changes: 1 addition & 1 deletion ...ders/DummyProviderForLanguageServiceTesting/DummyProviderForLanguageServiceTesting.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<PropertyGroup>
<TargetFramework>net472</TargetFramework>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<OtherFlags>$(OtherFlags) --nowarn:3390 --nowarn:3218 --nowarn:1182</OtherFlags>
<OtherFlags>$(OtherFlags) --nowarn:3390 --nowarn:3218 --nowarn:1182 --warnaserror-:1182</OtherFlags>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions vsintegration/tests/Salsa/VisualFSharp.Salsa.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<PropertyGroup>
<OutputType>Library</OutputType>
<NoWarn>$(NoWarn);44;45;47;52;58;75;1182</NoWarn><!-- 1182 - unused bindings, too many of them here -->
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<UsePackageTargetFallbackHack>true</UsePackageTargetFallbackHack>
<EnableDefaultEmbeddedResourceItems>false</EnableDefaultEmbeddedResourceItems>
Expand Down
1 change: 1 addition & 0 deletions vsintegration/tests/UnitTests/VisualFSharp.UnitTests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<PlatformTarget>x86</PlatformTarget>
<OutputType>Library</OutputType>
<NoWarn>$(NoWarn);44;58;75;3005;1182</NoWarn><!-- 1182 - unused bindings, too many of them here -->
<OtherFlags>$(OtherFlags) --warnaserror-:1182</OtherFlags>
<DisableImplicitFSharpCoreReference>true</DisableImplicitFSharpCoreReference>
<UsePackageTargetFallbackHack>true</UsePackageTargetFallbackHack>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
Expand Down