Remove a bunch of files from fantomas ignore #18407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
T-Gro
added
the
NO_RELEASE_NOTES
…/fsharp into try-less-fantomas-ignores
psfinaki
approved these changes
Mar 26, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
KevinRansom
approved these changes
Mar 27, 2025
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
This was referenced Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up doing a chore which was longer overdue:
clean up historical build flags for nullables, and use the one which ships with the SDK (
<Nullable>). This was not possible before, since our build was using last-known-good FSharp.BuildDrastically reduce the number of ifdefs, which were preventing Fantomas from working (ifdefs over entire val/let definitions work just fine, ifdefs for local parts like type argument constraints were making it fail)
Enable nullables unconditionally also for LKG and Proto builds
(1 special case still triggers warning which I had to nowarn. It is code generated code coming from the Fsharp resource task - the codegen comes from LKG FSharp.Build.dll, we have to wait a little)
With all of that, I could enable Fantomas for a big chunk of files, which is the reason for most of the diff here