Correct writeXmlDoc.addMembers #184
Conversation
Prevent members from being added to the global member list when the xmlDoc contains no content.
|
Can you add a quick test under |
To check that no empty members are generated.
|
@latkin Done. New xmlDoc005.fs test checks to make sure that names are generated for "Class1" but that there are no empty member names. This fails in current build, passes after this fix. |
|
Some of the existing XMLDoc tests (under XmlDoc\UnitOfMeasure) are now failing due to the change. Can you take a look and see if the tests need updating to match new (correct) behavior, or if there is some regression? |
|
👍 great |
These previously required there to be an empty "member" variable for the indices to match. Adjusted indices to match new, correct generated XML
|
@latkin Corrected those tests. Sorry I missed that the first round. This update should correct those tests to match the new, better generated content. In general, these tests are fairly brittle. They're all based on specific ordering of the XML (which, actually, is kind of backwards now, though fixing would break most of the tests again.) It might make sense, in the longer run, to revisit how they're setup and run. |
3 participants
Prevent members from being added to the global member list when the
xmlDoc contains no content.
Fixes #148