Update MSBuild

[psfinaki]

No description provided.

[github-actions]

✅ No release notes required

[psfinaki]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[psfinaki]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[psfinaki]

@dotnet/source-build PTAL. We have internal requirements to update this, please reach out privately if needed.

I tried a few options with the MSBuild dependency, eventually kind of followed what Roslyn does.

[mthalman]

The thing with Roslyn is that they don't actually need that configuration because 17.3.4 of MSBuild is already defined in SBRP which resolves those prebuilts. But with 17.12.6, that doesn't exist in the 9.0 branch of SBRP. I'll have to run a full VMR build with these changes to see if that version of MSBuild will be required to be defined in SBRP or not.

[psfinaki]

@mthalman sure, thanks, let me know how it goes.

[mthalman]

VMR build is clean so this is good to go.

[ellahathaway]

@mthalman - I just had a quick discussion with @KevinRansom on this PR.

Assuming that fsharp does not need to pin to a specific version of msbuild, can they set up a dependency flow of msbuild into their repo? That would help keep the prebuilt baseline clean(er) and avoid PRs like this one in the future.

[mthalman]

Sure, that would be great if it didn't need to be pinned to a specific version.

[KevinRansom]

@ellahathaway , @mthalman can you point us to some information describing how to do that?

Thanks

Kevin

[mthalman]

@ellahathaway , @mthalman can you point us to some information describing how to do that?

Thanks

Kevin

https://github.com/dotnet/arcade/blob/main/Documentation/DependencyFlowOnboarding.md

[psfinaki]

Thanks for the info. I'll be merging this - since this is an internal priority. Then I'll try to apply the guidelines above to the repo and submit a followup :)