"#if" directive around nullness removed fromsrc/Compiler/DependencyManager/DependencyProvider.fs and refactored.

[progressive-galib]

Description

"#if" directive around nullness removed fromsrc/Compiler/DependencyManager/DependencyProvider.fs and refactored.

Related: #18061 (partially addresses)

Checklist

• Release notes entry updated: in
  docs/release-notes/.FSharp.Compiler.Service/9.0.200.md,

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[T-Gro]

/run fantomas

[T-Gro]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[github-actions]

Failed to run fantomas: https://github.com/dotnet/fsharp/actions/runs/12667153205

[T-Gro]

Does "dotnet fantomas ." fail for you locally as well?
What if you manually try updating to a newer Fantomas version?
(if it is because of |null, it might need a tool update)

[Martin521]

I guess the changed files must temporarily be put into the nullness section of .fantomasignore until fantomas 7 is out.

[psfinaki]

So I took a look:

• dotnet fantomas . indeed fails locally here
• the fantomas version we have is the latest available in our feeds
• we could update the feeds and the fantomas version but the newest fantomas (6.3.16) just throws StackOverflow on our repo (even main)

(fyi @nojaf)

So I think @progressive-galib the best we can do here is to revert formatting changes (and also the ones which are deemed not necessary by @T-Gro) and put the DependencyProvider to the .fantomasignore.

Sorry for the inconvenience here, nulls shook the F# ecosystem a bit. Other files might cause less problems :)

[nojaf]

Hi,

Could you try the latest beta maybe? That has initial support for all the nullness stuff: https://www.nuget.org/packages/fantomas/7.0.0-beta-001

You PR here will need to be ignored (via .fantomasignore) as it seems to have nullness syntax.

[psfinaki]

I think it behaves differently and does some changes, but eventually the beta also throws SO :/

[nojaf]

@psfinaki could you share some more details? Latest beta worked for me on this branch.

[progressive-galib]

@psfinaki could you share some more details? Latest beta worked for me on this branch.

could you push cause it fails on my machine.

[nojaf]

You need to ignore the file for now.

[psfinaki]

@progressive-galib sure, I pushed the changes to the PR.

[psfinaki]

@nojaf that's what I'm getting in the main:

I can create a fantomas issue if you wish :)

[nojaf]

I can create a fantomas issue if you wish :)

Only if it is a meaningful one, I'd say 😉. If your issue will be "hey we have a stack overflow somewhere in this codebase" then I wouldn't bother.

[psfinaki]

I'll merge this @progressive-galib. Thanks for addressing it!