Skip to content

Handle some flaky ProjectAnalysisTests cases #18200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025
Merged

Handle some flaky ProjectAnalysisTests cases #18200

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e4a67e
run type provider tests in sequence
majocha Jan 3, 2025
a836627
Merge branch 'main' into Fix-flaky-test
psfinaki Jan 6, 2025
0bc085a
Merge branch 'main' into Fix-flaky-test
majocha Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/FSharp.Compiler.Service.Tests/ProjectAnalysisTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3691,15 +3691,15 @@ let _ = XmlProvider<"<root><value>1</value><value>3</value></root>">.GetSample()
let options = { checker.GetProjectOptionsFromCommandLineArgs (projFileName, args) with SourceFiles = fileNames }

// ".NET Core SKIPPED: Disabled until FSharp.Data.dll is build for dotnet core."
[<FactForDESKTOP>]
[<FactForDESKTOP; RunTestCasesInSequence>]
let ``Test Project25 whole project errors`` () =
let wholeProjectResults = checker.ParseAndCheckProject(Project25.options) |> Async.RunImmediate
for e in wholeProjectResults.Diagnostics do
printfn "Project25 error: <<<%s>>>" e.Message
wholeProjectResults.Diagnostics.Length |> shouldEqual 0

// ".NET Core SKIPPED: Disabled until FSharp.Data.dll is build for dotnet core."
[<FactForDESKTOP>]
[<FactForDESKTOP; RunTestCasesInSequence>]
let ``Test Project25 symbol uses of type-provided members`` () =
let wholeProjectResults = checker.ParseAndCheckProject(Project25.options) |> Async.RunImmediate
let backgroundParseResults1, backgroundTypedParse1 =
Expand Down Expand Up @@ -3756,8 +3756,8 @@ let ``Test Project25 symbol uses of type-provided members`` () =
usesOfGetSampleSymbol |> shouldEqual [|("file1", ((5, 8), (5, 25))); ("file1", ((10, 8), (10, 78)))|]

// ".NET Core SKIPPED: Disabled until FSharp.Data.dll is build for dotnet core.")>]
[<FactForDESKTOP>]
let ``Test symbol uses of type-provided types`` () =
[<FactForDESKTOP; RunTestCasesInSequence>]
let ``Test Project25 symbol uses of type-provided types`` () =
let wholeProjectResults = checker.ParseAndCheckProject(Project25.options) |> Async.RunImmediate
let backgroundParseResults1, backgroundTypedParse1 =
checker.GetBackgroundCheckResultsForFileInProject(Project25.fileName1, Project25.options)
Expand All @@ -3776,8 +3776,8 @@ let ``Test symbol uses of type-provided types`` () =

usesOfGetSampleSymbol |> shouldEqual [|("file1", ((4, 15), (4, 26))); ("file1", ((10, 8), (10, 19)))|]

[<Fact>]
let ``Test symbol uses of fully-qualified records`` () =
[<Fact; RunTestCasesInSequence>]
let ``Test Project25 symbol uses of fully-qualified records`` () =
let wholeProjectResults = checker.ParseAndCheckProject(Project25.options) |> Async.RunImmediate
let backgroundParseResults1, backgroundTypedParse1 =
checker.GetBackgroundCheckResultsForFileInProject(Project25.fileName1, Project25.options)
Expand Down
Loading