FSI: improve thread-safety #18152
Merged
FSI: improve thread-safety #18152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
psfinaki
added
the
NO_RELEASE_NOTES
majocha
changed the title
psfinaki
approved these changes
Dec 18, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://dev.azure.com/dnceng-public/public/_build/results?buildId=896555&view=ms.vss-test-web.build-test-results-tab&runId=23516108&resultId=104252&paneView=debug
Similar errors may be observed in other test cases in
ComponentTests.Scriptingwhen "run until failure" in parallel.FsiHelpused non thread-safeDictionaryfor caching, resulting in intermittent test failures.The above problems affect mostly the test suite but can theoretically show up IRL when more than one fsi sessions are created and used concurrently.
This PR attempts to improve it. Verified locally by running some iterations of relevant tests. Let's see if it breaks anything else.