Skip to content

Re-enable TransparentCompiler tests, an errata #17986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Re-enable TransparentCompiler tests, an errata #17986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/FSharp.Compiler.ComponentTests/CompilerService/AsyncMemoize.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@ let tap f x = f x; x

let internal record (cache: AsyncMemoize<_,_,_>) =

let events = ResizeArray()
let events = Collections.Concurrent.ConcurrentQueue()

let waitForIdle() = SpinWait.SpinUntil(fun () -> not cache.Updating)

waitForIdle()
cache.Event
|> Event.map (fun (e, (_, k, _)) -> e, k)
|> Event.add events.Add
|> Event.add events.Enqueue

let getEvents () =
waitForIdle()
Expand Down
4 changes: 2 additions & 2 deletions tests/FSharp.Compiler.ComponentTests/FSharpChecker/TransparentCompiler.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ let fileName fileId = $"File%s{fileId}.fs"

let internal recordAllEvents groupBy =
let mutable cache : AsyncMemoize<_,_,_> option = None
let events = ResizeArray()
let events = ConcurrentQueue()

let waitForIdle() = SpinWait.SpinUntil(fun () -> not cache.Value.Updating)

Expand All @@ -40,7 +40,7 @@ let internal recordAllEvents groupBy =
waitForIdle()
cache.Value.Event
|> Event.map (fun (e, k) -> groupBy k, e)
|> Event.add events.Add
|> Event.add events.Enqueue

let getEvents () =
waitForIdle()
Expand Down
Loading