Warnings for invalid #nowarn arguments #17871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
T-Gro
reviewed
Oct 16, 2024
edgarfgp
approved these changes
Oct 17, 2024
KevinRansom
previously requested changes
Oct 17, 2024
tests/FSharp.Compiler.ComponentTests/CompilerDirectives/NonStringArgs.fs
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/CompilerDirectives/NonStringArgs.fs
Outdated
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/CompilerDirectives/NonStringArgs.fs
Outdated
Show resolved
Hide resolved
T-Gro
reviewed
Nov 1, 2024
T-Gro
reviewed
Nov 1, 2024
T-Gro
reviewed
Nov 1, 2024
T-Gro
reviewed
Nov 1, 2024
T-Gro
reviewed
Nov 1, 2024
T-Gro
approved these changes
Nov 4, 2024
0101
approved these changes
Nov 4, 2024
Co-authored-by: Petr Pokorny <[email protected]>
auto-merge was automatically disabled
November 4, 2024 14:05
Head branch was pushed to by a user without write access
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17871 in repo dotnet/fsharp |
|
This is ready |
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #17870
Also centralizes the distributed logic for processing #nowarn arguments, for better maintainability.
Checklist