Skip to content

CompilerOrder: set metadata for CompileFirst items #17820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2024
Merged

CompilerOrder: set metadata for CompileFirst items #17820

merged 2 commits into from
Oct 3, 2024

Conversation

@auduchinok
Copy link
Member

Follow-up for #17791. Fixes the remaining case.

@auduchinok auduchinok requested a review from a team as a code owner September 30, 2024 14:28
@github-actions
Copy link
Contributor

✅ No release notes required

@T-Gro T-Gro enabled auto-merge (squash) October 1, 2024 07:34
auto-merge was automatically disabled October 1, 2024 07:41

Head branch was pushed to by a user without write access

@auduchinok auduchinok force-pushed the compileOrder-compileFirst branch from 9cb2acc to b28417a Compare October 1, 2024 07:41
@auduchinok
Copy link
Member Author

It's ready.

@auduchinok
Copy link
Member Author

@vzarytovskii Could you guys please backport #17791 and this PR to .NET 8?

@vzarytovskii
Copy link
Member

@vzarytovskii Could you guys please backport #17791 and this PR to .NET 8?

It'll probably not gonna hit the approval bar. @KevinRansom

@KevinRansom
Copy link
Contributor

@auduchinok
Neither of these changes will make the backport bar. Without either of these changes, everything works as designed and intended. The bar for SDK changes, is along the lines of the bug breaks an existing designed feature, causes a serious program crash, obviously, security issues, and source code regressions.

KevinRansom
KevinRansom approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I'd never added CompileFirst and CompileLast. Come to think about it, I wish we could fix compile ordering to not be required.

@KevinRansom KevinRansom enabled auto-merge (squash) October 3, 2024 21:19
@KevinRansom KevinRansom merged commit dc2494a into dotnet:main Oct 3, 2024
32 checks passed
@KevinRansom
Copy link
Contributor

@auduchinok ---
we have given this some thought, chatted with a few people and we think we can try to includes these changes in the 8.0.4XX LTSbranch. There is no guarantee, but given that these are very low risk changes and there is no good work around for you we will try to argue the case.

KevinRansom added a commit to KevinRansom/fsharp that referenced this pull request Oct 4, 2024
@auduchinok @KevinRansom
CompilerOrder: set metadata for CompileFirst items (dotnet#17820)
643b656 
Co-authored-by: Kevin Ransom (msft) <[email protected]>
@auduchinok
Copy link
Member Author

@KevinRansom Thank you very much! That will be really great if it's possible to merge it there!

@auduchinok auduchinok deleted the compileOrder-compileFirst branch October 5, 2024 06:17
vzarytovskii pushed a commit that referenced this pull request Oct 7, 2024
@KevinRansom @auduchinok
Requires tactics Approval: Restore the ability to identify CompileBef…
8904b38 
…ore and CompileAfter values (#17838)

* Fix 17786 (#17791)

* CompilerOrder: set metadata for CompileFirst items (#17820)

Co-authored-by: Kevin Ransom (msft) <[email protected]>

* version

---------

Co-authored-by: Eugene Auduchinok <[email protected]>
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
This was referenced Sep 8, 2025
Closed
Open
This was referenced Oct 10, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@auduchinok @vzarytovskii @KevinRansom @edgarfgp @T-Gro