Skip to content

Readability of lex.fsl #17817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 10, 2024
Merged

Readability of lex.fsl #17817

merged 14 commits into from
Oct 10, 2024

Conversation

@Martin521
Copy link
Contributor

@Martin521 Martin521 commented Sep 30, 2024 •
edited
Loading

Description

I found reading and understanding lex.fsl not easy. To hopefully make it easier for future newcomers, I have tried to remove some hurdles.

This PR

  • renames some items to differentiate them from other items with the same name
  • removes the dysfunctional threading of a token through shouldStartLine
  • adds tests for the preprocessing directives (including one to guard the anywhite* "#if" ident_char+ rule of the lexer)
  • simplifies some code
  • adds a comment to explain the skip parameter
  • adds a comment to explain HASH_IDENT
  • intends not to change the lexing process and results in any way

I haven't tackled the big issues ;-)

Checklist

  • Test cases added

@Martin521 Martin521 requested a review from a team as a code owner September 30, 2024 09:17
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

T-Gro
T-Gro reviewed Sep 30, 2024
View reviewed changes
@Martin521 Martin521 marked this pull request as draft September 30, 2024 10:09
@Martin521 Martin521 marked this pull request as ready for review September 30, 2024 18:08
@Martin521
Copy link
Contributor Author

Can somebody add the NO_RELEASE_NOTES label?

@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Oct 2, 2024
@Martin521 Martin521 force-pushed the lexing-deobfuscation branch from 46794e5 to 905f4cc Compare October 9, 2024 13:58
@Martin521
Copy link
Contributor Author

This can be merged

@abonie abonie merged commit 789b067 into dotnet:main Oct 10, 2024
32 checks passed
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Closed
@dependabot dependabot bot mentioned this pull request Sep 8, 2025
Open
This was referenced Oct 10, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@abonie abonie abonie approved these changes

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Martin521 @vzarytovskii @abonie @T-Gro @edgarfgp