-
Couldn't load subscription status.
- Fork 833
Tests: remove dependency on CurrentDirectory ("test.ok" files) #17815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ No release notes required |
|
Tested contributor scenario on WIndows: Tests running fine. |
|
I also added BUILDING_USING_DOTNET condition to FSharpSuite.Tests. Now
Verifies the relevant test successfully runs |
This is mostly cherrypick from #17662.
A lot of FSharpSuite tests write a "test.ok" file to current dir to signal success. This is bad because current directory is a shared resource.
This makes them write to stdout instead.
Not pretty either, but Console.Out can be very simply intercepted in a multi-threaded way to unblock running those tests in parallel.
Inspired by #17709.