Revert "Move attribute enforcement from v9 to preview" #17752
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9df594.
|
T-Gro
reviewed
Sep 17, 2024
T-Gro
reviewed
Sep 17, 2024
|
The test regression should not be there, since Kevin's fixed address this. |
T-Gro
approved these changes
Sep 17, 2024
T-Gro
reviewed
Sep 17, 2024
edgarfgp
added
the
NO_RELEASE_NOTES
|
Just in case this PR gets merged instead of Kekin's . I think the tests should be using |
auto-merge was automatically disabled
September 18, 2024 10:53
Pull request was closed
T-Gro
deleted the
revert-17739-T-Gro-Move-LangFeature-AttrEnforcement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #17739, since the fix is in.
@T-Gro @KevinRansom should this go to lang version 9.1, since 9 is frozen for release?