Skip to content

Conversation

@nojaf
Copy link
Contributor

@nojaf nojaf commented Sep 16, 2024

Description

Fixes #17720
Fixes #17721

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@nojaf nojaf requested a review from a team as a code owner September 16, 2024 07:43
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024

✅ No release notes required

@vzarytovskii
Copy link
Member

Nice, thanks

@T-Gro T-Gro merged commit e668b90 into dotnet:main Sep 16, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Nullness issue - trivia for SynTypeConstraint.WhereTyparNotSupportsNull Nullness issue - Bar trivia in SynType.WithNull

3 participants