- 
                Notifications
    You must be signed in to change notification settings 
- Fork 834
Better error reporting for let bindings. #17601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | ❗ Release notes required
 
 | 
Co-authored-by: Brian Rourke Boll <[email protected]>
Co-authored-by: Brian Rourke Boll <[email protected]>
…fsharp into better-let-binding-error-range
…fsharp into better-let-binding-error-range
SynPat range for let binding errors| @psfinaki Thanks a lot for the help. You are a Legend. Will be updating the PR description soon to cover and explain all the goodness here :) | 
              
                    edgarfgp
  
              
              commented
              
                  
                    Aug 30, 2024 
                  
              
              
            
            
              
                    edgarfgp
  
              
              commented
              
                  
                    Aug 30, 2024 
                  
              
              
            
            
              
                    edgarfgp
  
              
              commented
              
                  
                    Aug 30, 2024 
                  
              
              
            
            
              
                    psfinaki
  
              
              reviewed
              
                  
                    Sep 2, 2024 
                  
              
              
            
            
        
          
                tests/FSharp.Compiler.ComponentTests/Miscellaneous/MigratedTypeCheckTests.fs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …fsharp into better-let-binding-error-range
              
                    psfinaki
  
              
              reviewed
              
                  
                    Sep 2, 2024 
                  
              
              
            
            
              
                    psfinaki
  
              
              reviewed
              
                  
                    Sep 2, 2024 
                  
              
              
            
            
        
          
                ...formance/BasicGrammarElements/MemberDefinitions/MethodsAndProperties/MethodsAndProperties.fs
          
            Show resolved
            Hide resolved
        
      
              
                    psfinaki
  
              
              reviewed
              
                  
                    Sep 2, 2024 
                  
              
              
            
            
              
                    vzarytovskii
  
              
              approved these changes
              
                  
                    Sep 4, 2024 
                  
              
              
            
            
              
                    psfinaki
  
              
              approved these changes
              
                  
                    Sep 4, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this this is in the good shape, thanks Edgar!
      
        
      
      
  
    2 tasks
  
  This was referenced Sep 11, 2024 
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Description
TcNormalizedBindingto use theSynPatrange to show more accurate error ranges.Before
After
Multi-case partial active patternsBefore
We just showed an unclear error message that did not make it clear that multi-case partial active patterns are not supported.
After
Before
FS0827: This is not a valid name for an active patternAfter
FS0827: (|A|B|)' is not a valid method name. Use a 'let' binding instead.Checklist