Default to .NET9

[vzarytovskii]

No description provided.

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[vzarytovskii]

@dotnet/source-build-internal folks, now when I have updated to net9 by default, it seems that SB is failing with

/__w/1/s/.dotnet/sdk/9.0.100-preview.6.24328.19/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error MSB4044: The "ResolvePackageAssets" task was not given a value for the required parameter "TargetFramework". [/__w/1/s/artifacts/source-build/self/src/buildtools/fslex/fslex.fsproj] [/__w/1/s/.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.24311.3/tools/Build.proj]
##[error].dotnet/sdk/9.0.100-preview.6.24328.19/Sdks/Microsoft.NET.Sdk/targets/Microsoft.PackageDependencyResolution.targets(266,5): error MSB4044: The "ResolvePackageAssets" task was not given a value for the required parameter "TargetFramework". [/__w/1/s/artifacts/source-build/self/src/buildtools/fslex/fslex.fsproj]

Do you happen to know what's wrong from the top of your head, before I started digging deeper? Is it arcade version/channel?

[vzarytovskii]

Ok, updating arcade fixed this particular issue, but now I'm getting new prebuilts:

##[error].packages/microsoft.dotnet.arcade.sdk/9.0.0-beta.24352.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 8 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.DotNet.Arcade.Sdk.9.0.0-beta.24352.2
Microsoft.DotNet.Build.Tasks.Feed.9.0.0-beta.24352.2
Microsoft.DotNet.NuGetRepack.Tasks.9.0.0-beta.24352.2
Microsoft.DotNet.SourceBuild.Tasks.9.0.0-beta.24352.2
Microsoft.DotNet.XliffTasks.9.0.0-beta.24352.2

@dotnet/source-build-internal @ViktorHofer maybe you folks know if I should add them to baseline, or shall those be fixed elsewhere?

[ViktorHofer]

@dotnet/source-build-internal @ViktorHofer maybe you folks know if I should add them to baseline, or shall those be fixed elsewhere?

You need to update the Version.Details.xml entries as well.

[vzarytovskii]

@dotnet/source-build-internal @ViktorHofer maybe you folks know if I should add them to baseline, or shall those be fixed elsewhere?

You need to update the Version.Details.xml entries as well.

Thanks, will check it out, not sure we have them explicitly already.

[ViktorHofer]

It might be sufficient to just bump this one: https://github.com/vzarytovskii/fsharp/blob/cf25ed0d0a774f663ae024b984c188aa951688c0/eng/Version.Details.xml#L45-L48

and remove the xliff entries.

[ViktorHofer]

You added xliff-tasks back, maybe by accident?

[vzarytovskii]

Yeah, probably copied from roslyn by accident. Will remove it later.

[vzarytovskii]

If it's green, I'm going to merge it + prepare 17.12 and insertions, so we have a chance of having a build today.