VS plugin Bugfix :: Defensive checks added to prevent TaskListService crashes #17411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Gro
added
the
NO_RELEASE_NOTES
|
|
/fantomas run |
|
/run fantomas |
Co-authored-by: T-Gro <[email protected]>
|
Any way to test this? |
psfinaki
approved these changes
Aug 14, 2024
abonie
approved these changes
Aug 15, 2024
This was referenced Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have been seeing unhandled exceptions coming from TaskListService usage in VS.
Those were coming from wrong arguments passed to IndexOf, caused by mismatches in columnar indexes.