Default GraphBasedChecking, ParallelOptimization and ParallelIlxGen optimizations #17400
Conversation
|
Caution Repository is on lockdown for maintenance, all merges are on hold. |
❗ Release notes required
|
tests/FSharp.Compiler.ComponentTests/TypeChecks/Graph/CompilationTests.fs
Outdated
Show resolved
Hide resolved
|
@vzarytovskii @KevinRansom. I would like to propose enabling the described optimizations by default. I'm using Kevin's |
|
Could you please mention in FCS changelog that we changed the defaults? |
Done. Not sure why the bot decided to put the |
| } | ||
| } | ||
|
|
||
| .method public static int32 select1(class Match01/Test1 x) cil managed |
There was a problem hiding this comment.
That doesn't look good, that it changed ordering. A potential determinism issue here
| int32 V_2, | ||
| int32 V_3, | ||
| class [runtime]System.Collections.IComparer V_4, | ||
| int32 V_5, |
There was a problem hiding this comment.
Also doesn't look good, unsure why baselines changed, ilx output should retain the same order
3 participants
Description
Enable by default:
Checklist