Fix exception checks in the tests #17326
Merged
+32
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
3 tasks
T-Gro
reviewed
Jun 19, 2024
T-Gro
reviewed
Jun 19, 2024
T-Gro
reviewed
Jun 19, 2024
tests/FSharp.Core.UnitTests/FSharp.Core/OperatorsModuleDynamic.fs
Outdated
Show resolved
Hide resolved
KevinRansom
approved these changes
Jun 20, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
abonie
approved these changes
Jun 25, 2024
Co-authored-by: Tomas Grosup <[email protected]>
Co-authored-by: Tomas Grosup <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
psfinaki
changed the title
T-Gro
approved these changes
Jun 25, 2024
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when reviewing this PR. The code throws
ArgumentOutOfRangeExceptionand the tests verifyArgumentException, here. Not good.CheckThrowsExnshould be adjusted to match the exception type, otherwise it only checks them within the type hierarchy.