source-build: don't use PublishReadyToRun on Mono-builds. #17300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crossgen2 is not built with Mono-based .NET SDKs.
Contributor
✅ No release notes required |
psfinaki
approved these changes
Jun 12, 2024
mthalman
reviewed
Jun 12, 2024
Member
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
@tmds - Just want to check whether this has been tested in the context of the VMR. I'm wondering whether SourceBuildUseMonoRuntime gets flowed to this point in the build. I see you flow it in via SourceBuild.props, but still wondering whether it's correctly set by that point.
Member
Author
|
@mthalman I tested these changes with vmr builds. |
mthalman
approved these changes
Jun 12, 2024
KevinRansom
approved these changes
Jun 13, 2024
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossgen2 is not built with Mono-based .NET SDKs.
Fixes dotnet/source-build#4463.
@ViktorHofer @KevinRansom @MichaelSimons ptal
cc @omajid