Skip to content

Fix MultipleDiagnosticsLoggers.Parallel deadlock #17208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 23, 2024
Merged

Fix MultipleDiagnosticsLoggers.Parallel deadlock #17208

merged 6 commits into from
May 23, 2024

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented May 21, 2024

Description

Fixes #17205

Checklist

  • Test case added

@majocha majocha requested a review from a team as a code owner May 21, 2024 22:32
@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@majocha
Copy link
Contributor Author

majocha commented May 22, 2024

I think this is ready.

@psfinaki
Copy link
Contributor

@ForNeVeR maybe take a look if you have a chance :)

ForNeVeR
ForNeVeR approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@ForNeVeR ForNeVeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I cannot imagine a scenario when this breaks (so far!)

@vzarytovskii
Copy link
Member

LGTM. I cannot imagine a scenario when this breaks (so far!)

Famous last words, but lgtm too

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label May 22, 2024
@vzarytovskii
Copy link
Member

/run fantomas

@dotnet dotnet deleted a comment from github-actions bot May 22, 2024
@dotnet dotnet deleted a comment from psfinaki May 22, 2024
@psfinaki
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dotnet dotnet deleted a comment from github-actions bot May 23, 2024
@vzarytovskii vzarytovskii merged commit 6420e36 into dotnet:main May 23, 2024
@majocha majocha deleted the fix-parallel branch May 23, 2024 14:21
This was referenced May 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@ForNeVeR ForNeVeR ForNeVeR approved these changes

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MultipleDiagnosticsLoggers.Parallel deadlock

5 participants

@majocha @psfinaki @vzarytovskii @ForNeVeR @T-Gro