Skip to content

Error for partial implementation of interface with static and non static abstract members #17160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 17, 2024
Merged

Error for partial implementation of interface with static and non static abstract members #17160

merged 5 commits into from
May 17, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented May 16, 2024 •
edited
Loading

Description

Fixes #17138

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 16, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

vzarytovskii
vzarytovskii reviewed May 16, 2024
View reviewed changes
@edgarfgp edgarfgp marked this pull request as ready for review May 16, 2024 19:56
@edgarfgp edgarfgp requested a review from a team as a code owner May 16, 2024 19:56
@edgarfgp edgarfgp requested a review from vzarytovskii May 17, 2024 08:17
@T-Gro T-Gro enabled auto-merge (squash) May 17, 2024 10:28
@T-Gro T-Gro merged commit c83adae into dotnet:main May 17, 2024
@edgarfgp
Copy link
Contributor Author

👍

This was referenced May 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

@vzarytovskii vzarytovskii Awaiting requested review from vzarytovskii

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No compile-time error for partial implementation of interface with static abstract members
4 participants
@edgarfgp @vzarytovskii @psfinaki @T-Gro