Skip to content

Consolidate emitted IL for-loop tests #17128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2024
Merged

Consolidate emitted IL for-loop tests #17128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a98c2a3
Consolidate emitted IL `for`-loop tests
brianrourkeboll May 9, 2024
08a1d4d
Merge branch 'main' of https://github.com/dotnet/fsharp into forloop-…
brianrourkeboll May 9, 2024
03bd399
Update netfx baselines
brianrourkeboll May 9, 2024
509d38f
Fix find/replace bug
brianrourkeboll May 9, 2024
a472566
Unify netstandard assembly version in IL
brianrourkeboll May 9, 2024
fd45ce1
Re-update baselines
brianrourkeboll May 9, 2024
38f772a
Merge branch 'main' into forloop-realsig-consolidate
KevinRansom May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...lInternalSignatureOff/ForEachOnArray01.fs → ...sts/EmittedIL/ForLoop/ForEachOnArray01.fs
View file
Open in desktop
File renamed without changes.
0 ...alSignatureOff/ForEachOnArray01.fs.il.bsl → ...rray01.fs.RealInternalSignatureOff.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...nalSignatureOn/ForEachOnArray01.fs.il.bsl → ...Array01.fs.RealInternalSignatureOn.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...alInternalSignatureOff/ForEachOnList01.fs → ...ests/EmittedIL/ForLoop/ForEachOnList01.fs
View file
Open in desktop
File renamed without changes.
18 changes: 6 additions & 12 deletions ...ForEachOnList01.fs.il.netcore.release.bsl → ...List01.fs.RealInternalSignatureOff.il.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<int32,int32>
{
.field static assembly initonly class assembly/test6@38 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -64,8 +63,7 @@
IL_0006: ret
}

.method public strict virtual instance int32
Invoke(int32 x) cil managed
.method public strict virtual instance int32 Invoke(int32 x) cil managed
{

.maxstack 8
Expand All @@ -75,8 +73,7 @@
IL_0003: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand All @@ -91,8 +88,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<int32,int32>
{
.field static assembly initonly class assembly/test7@47 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -103,8 +99,7 @@
IL_0006: ret
}

.method public strict virtual instance int32
Invoke(int32 x) cil managed
.method public strict virtual instance int32 Invoke(int32 x) cil managed
{

.maxstack 8
Expand All @@ -114,8 +109,7 @@
IL_0003: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand Down
18 changes: 6 additions & 12 deletions ...ForEachOnList01.fs.il.netcore.release.bsl → ...nList01.fs.RealInternalSignatureOn.il.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<int32,int32>
{
.field static assembly initonly class assembly/test6@38 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -64,8 +63,7 @@
IL_0006: ret
}

.method public strict virtual instance int32
Invoke(int32 x) cil managed
.method public strict virtual instance int32 Invoke(int32 x) cil managed
{

.maxstack 8
Expand All @@ -75,8 +73,7 @@
IL_0003: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand All @@ -91,8 +88,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<int32,int32>
{
.field static assembly initonly class assembly/test7@47 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -103,8 +99,7 @@
IL_0006: ret
}

.method public strict virtual instance int32
Invoke(int32 x) cil managed
.method public strict virtual instance int32 Invoke(int32 x) cil managed
{

.maxstack 8
Expand All @@ -114,8 +109,7 @@
IL_0003: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand Down
0 ...InternalSignatureOff/ForEachOnString01.fs → ...ts/EmittedIL/ForLoop/ForEachOnString01.fs
View file
Open in desktop
File renamed without changes.
18 changes: 6 additions & 12 deletions ...rEachOnString01.fs.il.netcore.release.bsl → ...ring01.fs.RealInternalSignatureOff.il.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<char,char>
{
.field static assembly initonly class assembly/test8@54 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -64,8 +63,7 @@
IL_0006: ret
}

.method public strict virtual instance char
Invoke(char x) cil managed
.method public strict virtual instance char Invoke(char x) cil managed
{

.maxstack 8
Expand All @@ -77,8 +75,7 @@
IL_0005: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand All @@ -93,8 +90,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<char,char>
{
.field static assembly initonly class assembly/test9@63 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -105,8 +101,7 @@
IL_0006: ret
}

.method public strict virtual instance char
Invoke(char x) cil managed
.method public strict virtual instance char Invoke(char x) cil managed
{

.maxstack 8
Expand All @@ -118,8 +113,7 @@
IL_0005: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand Down
18 changes: 6 additions & 12 deletions ...rEachOnString01.fs.il.netcore.release.bsl → ...tring01.fs.RealInternalSignatureOn.il.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<char,char>
{
.field static assembly initonly class assembly/test8@54 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -64,8 +63,7 @@
IL_0006: ret
}

.method public strict virtual instance char
Invoke(char x) cil managed
.method public strict virtual instance char Invoke(char x) cil managed
{

.maxstack 8
Expand All @@ -77,8 +75,7 @@
IL_0005: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand All @@ -93,8 +90,7 @@
extends class [FSharp.Core]Microsoft.FSharp.Core.FSharpFunc`2<char,char>
{
.field static assembly initonly class assembly/test9@63 @_instance
.method assembly specialname rtspecialname
instance void .ctor() cil managed
.method assembly specialname rtspecialname instance void .ctor() cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.custom instance void [runtime]System.Diagnostics.DebuggerNonUserCodeAttribute::.ctor() = ( 01 00 00 00 )
Expand All @@ -105,8 +101,7 @@
IL_0006: ret
}

.method public strict virtual instance char
Invoke(char x) cil managed
.method public strict virtual instance char Invoke(char x) cil managed
{

.maxstack 8
Expand All @@ -118,8 +113,7 @@
IL_0005: ret
}

.method private specialname rtspecialname static
void .cctor() cil managed
.method private specialname rtspecialname static void .cctor() cil managed
{

.maxstack 10
Expand Down
0 ...ernalSignatureOff/ForEachRangeStepByte.fs → ...EmittedIL/ForLoop/ForEachRangeStepByte.fs
View file
Open in desktop
File renamed without changes.
0 ...ureOff/ForEachRangeStepByte.fs.opt.il.bsl → ...te.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...tureOn/ForEachRangeStepByte.fs.opt.il.bsl → ...yte.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...ernalSignatureOff/ForEachRangeStepChar.fs → ...EmittedIL/ForLoop/ForEachRangeStepChar.fs
View file
Open in desktop
File renamed without changes.
0 ...ureOff/ForEachRangeStepChar.fs.opt.il.bsl → ...ar.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...tureOn/ForEachRangeStepChar.fs.opt.il.bsl → ...har.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...rnalSignatureOff/ForEachRangeStepInt16.fs → ...mittedIL/ForLoop/ForEachRangeStepInt16.fs
View file
Open in desktop
File renamed without changes.
0 ...reOff/ForEachRangeStepInt16.fs.opt.il.bsl → ...16.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...ureOn/ForEachRangeStepInt16.fs.opt.il.bsl → ...t16.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...rnalSignatureOff/ForEachRangeStepInt32.fs → ...mittedIL/ForLoop/ForEachRangeStepInt32.fs
View file
Open in desktop
File renamed without changes.
0 ...reOff/ForEachRangeStepInt32.fs.opt.il.bsl → ...32.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...ureOn/ForEachRangeStepInt32.fs.opt.il.bsl → ...t32.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...rnalSignatureOff/ForEachRangeStepInt64.fs → ...mittedIL/ForLoop/ForEachRangeStepInt64.fs
View file
Open in desktop
File renamed without changes.
0 ...reOff/ForEachRangeStepInt64.fs.opt.il.bsl → ...64.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...ureOn/ForEachRangeStepInt64.fs.opt.il.bsl → ...t64.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...nalSignatureOff/ForEachRangeStepIntPtr.fs → ...ittedIL/ForLoop/ForEachRangeStepIntPtr.fs
View file
Open in desktop
File renamed without changes.
0 ...eOff/ForEachRangeStepIntPtr.fs.opt.il.bsl → ...tr.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...reOn/ForEachRangeStepIntPtr.fs.opt.il.bsl → ...Ptr.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...rnalSignatureOff/ForEachRangeStepSByte.fs → ...mittedIL/ForLoop/ForEachRangeStepSByte.fs
View file
Open in desktop
File renamed without changes.
0 ...reOff/ForEachRangeStepSByte.fs.opt.il.bsl → ...te.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...ureOn/ForEachRangeStepSByte.fs.opt.il.bsl → ...yte.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...nalSignatureOff/ForEachRangeStepUInt16.fs → ...ittedIL/ForLoop/ForEachRangeStepUInt16.fs
View file
Open in desktop
File renamed without changes.
0 ...eOff/ForEachRangeStepUInt16.fs.opt.il.bsl → ...16.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...reOn/ForEachRangeStepUInt16.fs.opt.il.bsl → ...t16.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...nalSignatureOff/ForEachRangeStepUInt32.fs → ...ittedIL/ForLoop/ForEachRangeStepUInt32.fs
View file
Open in desktop
File renamed without changes.
0 ...eOff/ForEachRangeStepUInt32.fs.opt.il.bsl → ...32.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...reOn/ForEachRangeStepUInt32.fs.opt.il.bsl → ...t32.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...nalSignatureOff/ForEachRangeStepUInt64.fs → ...ittedIL/ForLoop/ForEachRangeStepUInt64.fs
View file
Open in desktop
File renamed without changes.
0 ...eOff/ForEachRangeStepUInt64.fs.opt.il.bsl → ...64.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...reOn/ForEachRangeStepUInt64.fs.opt.il.bsl → ...t64.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...alSignatureOff/ForEachRangeStepUIntPtr.fs → ...ttedIL/ForLoop/ForEachRangeStepUIntPtr.fs
View file
Open in desktop
File renamed without changes.
0 ...Off/ForEachRangeStepUIntPtr.fs.opt.il.bsl → ...tr.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...eOn/ForEachRangeStepUIntPtr.fs.opt.il.bsl → ...Ptr.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...ureOff/ForEachRangeStep_UnitsOfMeasure.fs → ...orLoop/ForEachRangeStep_UnitsOfMeasure.fs
View file
Open in desktop
File renamed without changes.
0 ...achRangeStep_UnitsOfMeasure.fs.opt.il.bsl → ...re.fs.RealInternalSignatureOff.opt.il.bsl
View file
Open in desktop
File renamed without changes.
0 ...achRangeStep_UnitsOfMeasure.fs.opt.il.bsl → ...ure.fs.RealInternalSignatureOn.opt.il.bsl
View file
Open in desktop
File renamed without changes.
Loading