Skip to content

Error when property has same name as DU case #17088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 30, 2024
Merged

Error when property has same name as DU case #17088

merged 14 commits into from
Apr 30, 2024

Conversation

@edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Apr 25, 2024 •
edited
Loading

Description

Fixes #16646

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md

@edgarfgp edgarfgp mentioned this pull request Apr 25, 2024
Closed
3 tasks
@edgarfgp edgarfgp changed the title Error when property has same name as DU case #16760 Error when property has same name as DU case Apr 25, 2024
@edgarfgp edgarfgp marked this pull request as ready for review April 26, 2024 08:12
@edgarfgp edgarfgp requested a review from a team as a code owner April 26, 2024 08:12
@edgarfgp
Copy link
Contributor Author

This is ready

psfinaki
psfinaki reviewed Apr 26, 2024
View reviewed changes
psfinaki
psfinaki reviewed Apr 26, 2024
View reviewed changes
psfinaki
psfinaki approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@edgarfgp
Copy link
Contributor Author

Can I have another review please ?

@psfinaki
Copy link
Contributor

@dotnet/fsharp-team-msft

@psfinaki psfinaki enabled auto-merge (squash) April 30, 2024 09:18
@psfinaki psfinaki merged commit 8f329cb into dotnet:main Apr 30, 2024
@vzarytovskii
Copy link
Member

Nice, thanks!

@dotnet-bot dotnet-bot mentioned this pull request May 11, 2024
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected FS0812 when property has same name as DU case

3 participants

@edgarfgp @psfinaki @vzarytovskii