Skip to content

Conversation

@TheAngryByrd
Copy link
Contributor

@TheAngryByrd TheAngryByrd commented Apr 24, 2024

Description

Comments out a check that can cause the TransparentCompiler to throw an exception if a signature file is next next to a source file.

Fixes #17082

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

@TheAngryByrd TheAngryByrd requested a review from a team as a code owner April 24, 2024 13:06
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@TheAngryByrd TheAngryByrd changed the title Comments out signature file adjacency check in TransparentCompiler Removes signature file adjacency check in TransparentCompiler Apr 24, 2024
@TheAngryByrd TheAngryByrd force-pushed the transparent-compiler-signature-not-adjacent-exception branch from 0ba21c8 to 6099d8c Compare April 24, 2024 13:15
@TheAngryByrd
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 25, 2024
@psfinaki psfinaki merged commit 8653ab3 into dotnet:main Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Transparent Compiler: Fails when signature file is not exactly next to source file

4 participants