Don't split resumable code #17076
Merged
Don't split resumable code #17076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
|
I think I saw this warning suppressed in a couple of our projects (at least editor and editor.tests) - can the suppression be removed there now? |
No, this fixes only specific case - when it was caused by function split. Others should be worked on 1 by 1, besides it's only ignored in tests, and this warning ( |
psfinaki
approved these changes
Apr 22, 2024
T-Gro
approved these changes
Apr 23, 2024
psfinaki
pushed a commit
that referenced
this pull request
Apr 23, 2024
Co-authored-by: Vlad Zarytovskii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decision tree splitting during optimisation had some low-ish thresholds, here we make sure we don't ever split if we see resumable code invocation (in this case we check for the application for Run/Delay, etc).
Fixes #16068
Checklist