Skip to content

Conversation

@KevinRansom
Copy link
Contributor

Fixes #16771

For years CompileBefore and CompileAfter have been used to position generated files in the FSharp project build.

However, they are not WellKnown supported dotnet sdk collections. This PR changes this by allowing BeforeCompile and AfterCompile to be specified as metadata attached to CompileItems.

Note:

  1. In order to maintain compatibility with existing projects that may use CompileBefore and CompileAfter we maintain support for them
  2. The existing FSharp repo build will continue to use CompileBefore and CompileAfter collections, to avoid rewriting their build targets.

@KevinRansom KevinRansom requested a review from a team as a code owner April 16, 2024 19:26
@github-actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 16, 2024
@T-Gro
Copy link
Member

T-Gro commented Apr 19, 2024

Does this need docs changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

FSharps use of CompileBefore for file ordering leads to issues with other SDK components

3 participants