Skip to content

Fix plain dotnet build #16814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix plain dotnet build #16814

merged 1 commit into from
Mar 5, 2024

Conversation

@vzarytovskii
Copy link
Member

@vzarytovskii vzarytovskii commented Mar 5, 2024 •
edited
Loading

This fixes building with just dotnet build - do not pass realsig flag. Can be removed when compiler with that flag releases.

@vzarytovskii vzarytovskii requested a review from a team as a code owner March 5, 2024 14:26
@vzarytovskii vzarytovskii enabled auto-merge (squash) March 5, 2024 14:27
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 5, 2024
@vzarytovskii vzarytovskii merged commit 9b19710 into dotnet:main Mar 5, 2024
@dotnet-bot dotnet-bot mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vzarytovskii @psfinaki @abonie