-
Couldn't load subscription status.
- Fork 833
Shift multiline paren contents less aggressively #16789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* The logic in dotnet#16666 addressed some multiline parentheses removal issues, but it was slightly too aggressive and sometimes shifted lines farther than was necessary or safe.
❗ Release notes required
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Another followup to #16079.
Description
The logic in #16666 addressed some multiline parentheses removal issues, but it was slightly too aggressive and sometimes shifted lines farther than was necessary or safe.
For example, before #16666, the following code —
— when the unnecessary parentheses code fix was applied, would become —
— which was incorrect.
After #16666, it would become —
— which was more correct in one way (
longFunctionNameneeded to be shifted left), but less correct in another (the arguments tolongFunctionNamewere shifted too far).With this PR, it now correctly becomes:
Checklist