Skip to content

Conversation

@dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Feb 28, 2024

Description

This uses the same mechanism we used to fix the range start of INTERP_STRING_END to also fix the range start of INTERP_STRING_PART.
Not pretty but should do till I come up with a better approach.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

…G_END to also fix the range start of INTERP_STRING_PART
@dawedawe dawedawe requested a review from a team as a code owner February 28, 2024 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any ideas on how to make this actually a "pretty" fix? :)

@dawedawe
Copy link
Contributor Author

Any ideas on how to make this actually a "pretty" fix? :)

I think, we should find a solution that doesn't need special handling in pars.fsy.
I tried something with 4d01cda but there's more to it...
I'll work on a follow up clean up PR in the next couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants