-
Notifications
You must be signed in to change notification settings - Fork 834
Fix range start of INTERP_STRING_PART #16785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix range start of INTERP_STRING_PART #16785
Conversation
…G_END to also fix the range start of INTERP_STRING_PART
❗ Release notes required
|
- clean up work around structures introduced before and not needed anymore with this
This reverts commit 4d01cda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas on how to make this actually a "pretty" fix? :)
I think, we should find a solution that doesn't need special handling in |
Description
This uses the same mechanism we used to fix the range start of INTERP_STRING_END to also fix the range start of INTERP_STRING_PART.
Not pretty but should do till I come up with a better approach.
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: