fix wrong range start of INTERP_STRING_END #16774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Release notes required
|
abonie
approved these changes
Feb 27, 2024
edgarfgp
approved these changes
Feb 27, 2024
psfinaki
approved these changes
Feb 27, 2024
|
Thanks Dave :) |
psfinaki
pushed a commit
that referenced
this pull request
Feb 28, 2024
* Fix 16105 - Release inline optimization leads to MethodAccessException if used with assembly:InternalsVisibleTo attribute (#16737) * Fix16105 * trimming * Update release notes --------- Co-authored-by: Vlad Zarytovskii <[email protected]> * fix wrong range start of INTERP_STRING_END (#16774) * fix wrong range start of INTERP_STRING_END * add release notes entry --------- Co-authored-by: Adam Boniecki <[email protected]> * Update dependencies from https://github.com/dotnet/arcade build 20240223.1 (#16776) Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.24113.2 -> To Version 8.0.0-beta.24123.1 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Kevin Ransom (msft) <[email protected]> * remove superseded test of TryGetRecentCheckResultsForFile (#16770) * remove superseded test of TryGetRecentCheckResultsForFile * kick CI * Allow e2e tests to fail for now * Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20240227.2 (#16777) Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 9.0.0-alpha.1.24123.3 -> To Version 9.0.0-alpha.1.24127.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> --------- Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: dawe <[email protected]> Co-authored-by: Adam Boniecki <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ain't nothing pretty here.
It tries to fix the somewhat long-standing issue of the wrong range start of INTERP_STRING_END
Fixes #16418
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: