Skip to content

remove superseded test of TryGetRecentCheckResultsForFile #16770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

remove superseded test of TryGetRecentCheckResultsForFile #16770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f2b811
remove superseded test of TryGetRecentCheckResultsForFile
dawedawe Feb 26, 2024
1e00be4
kick CI
dawedawe Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions tests/service/ProjectAnalysisTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5462,66 +5462,6 @@ type A(i:int) =
| Some decl -> failwithf "unexpected declaration %A" decl
| None -> failwith "declaration list is empty"

[<Test>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``TryGetRecentCheckResultsForFile called with snapshot returns cached result after ParseAndCheckFile`` useTransparentCompiler =
let fileName1 = Path.ChangeExtension(tryCreateTemporaryFileName (), ".fs")
let base2 = tryCreateTemporaryFileName ()
let dllName = Path.ChangeExtension(base2, ".dll")
let projFileName = Path.ChangeExtension(base2, ".fsproj")
let fileSource1Text = """
type A(i:int) =
member x.Value = i
"""
let fileSource1 = SourceText.ofString fileSource1Text
FileSystem.OpenFileForWriteShim(fileName1).Write(fileSource1Text)

let fileNames = [|fileName1|]
let args = mkProjectCommandLineArgs (dllName, [])
let checker = FSharpChecker.Create(useTransparentCompiler=useTransparentCompiler)
let options = { checker.GetProjectOptionsFromCommandLineArgs (projFileName, args) with SourceFiles = fileNames }
let snapshot = FSharpProjectSnapshot.FromOptions(options, DocumentSource.FileSystem) |> Async.RunImmediate

let rbefore = checker.TryGetRecentCheckResultsForFile(fileName1, snapshot)
match rbefore with
| Some(fileResults, checkFileResults) -> failwith "cached results before ParseAndCheckFileInProject was called"
| None -> ()

checker.ParseAndCheckFileInProject(fileName1, snapshot) |> Async.RunImmediate
|> function
| _, FSharpCheckFileAnswer.Succeeded(res) -> ()
| _ -> failwithf "Parsing aborted unexpectedly..."

let rafterCheckResults = checker.TryGetRecentCheckResultsForFile(fileName1, snapshot)
match rafterCheckResults with
| Some(fileResults, checkFileResults) -> ()
| None -> failwith "no results from TryGetRecentCheckResultsForFile"

let fileSource1TextEdited = """
type A(i:int) =
member x.Value = i
member x.Value2 = 23
"""
let fileSource1Edited = SourceText.ofString fileSource1TextEdited
FileSystem.OpenFileForWriteShim(fileName1).Write(fileSource1TextEdited)
let snapshotAfterFileEdit = FSharpProjectSnapshot.FromOptions(options, DocumentSource.FileSystem) |> Async.RunImmediate

let rafterEditBefore2ndCheckResults = checker.TryGetRecentCheckResultsForFile(fileName1, snapshotAfterFileEdit)
match rafterEditBefore2ndCheckResults with
| Some(fileResults, checkFileResults) -> failwith "stale cache results from TryGetRecentCheckResultsForFile after edit"
| None -> ()

checker.ParseAndCheckFileInProject(fileName1, snapshotAfterFileEdit) |> Async.RunImmediate
|> function
| _, FSharpCheckFileAnswer.Succeeded(res) -> ()
| _ -> failwithf "Parsing aborted unexpectedly..."

let rafterEditAfter2ndCheckResults = checker.TryGetRecentCheckResultsForFile(fileName1, snapshotAfterFileEdit)
match rafterEditAfter2ndCheckResults with
| Some(fileResults, checkFileResults) -> ()
| None -> failwith "no results from TryGetRecentCheckResultsForFile"

[<TestCase(([||]: string[]), ([||]: bool[]))>]
[<TestCase([| "--times" |], [| false |])>]
[<TestCase([| "--times"; "--nowarn:75" |], ([||]: bool[]))>]
Expand Down