Skip to content

Disable flaky transparent compiler tests #16765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024
+10 −10
Merged

Disable flaky transparent compiler tests #16765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43024cc
Disable flaky transparent compiler tests
vzarytovskii Feb 26, 2024
ee1c2e6
Merge branch 'main' into vzarytovskii-patch-24
KevinRansom Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tests/service/ProjectAnalysisTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4655,7 +4655,7 @@ let callToOverload = B(5).Overload(4)
let args = mkProjectCommandLineArgs (dllName, [])

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Test project36 FSharpMemberOrFunctionOrValue.IsBaseValue`` useTransparentCompiler =
let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
Expand All @@ -4672,7 +4672,7 @@ let ``Test project36 FSharpMemberOrFunctionOrValue.IsBaseValue`` useTransparentC
|> fun baseSymbol -> shouldEqual true baseSymbol.IsBaseValue

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Test project36 FSharpMemberOrFunctionOrValue.IsConstructorThisValue & IsMemberThisValue`` useTransparentCompiler =
let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
Expand Down Expand Up @@ -4711,7 +4711,7 @@ let ``Test project36 FSharpMemberOrFunctionOrValue.IsConstructorThisValue & IsMe
|> shouldEqual true

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Test project36 FSharpMemberOrFunctionOrValue.LiteralValue`` useTransparentCompiler =
let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
Expand Down Expand Up @@ -5329,7 +5329,7 @@ let foo (a: Foo): bool =
let options = { checker.GetProjectOptionsFromCommandLineArgs (projFileName, args) with SourceFiles = fileNames }

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Test typed AST for struct unions`` useTransparentCompiler = // See https://github.com/fsharp/FSharp.Compiler.Service/issues/756
let keepAssemblyContentsChecker = FSharpChecker.Create(keepAssemblyContents=true, useTransparentCompiler=useTransparentCompiler)
Expand Down Expand Up @@ -5419,7 +5419,7 @@ let ``Test diagnostics with line directives ignored`` () =
//------------------------------------------------------

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``ParseAndCheckFileResults contains ImplFile list if FSharpChecker is created with keepAssemblyContent flag set to true`` useTransparentCompiler =

Expand Down Expand Up @@ -5463,7 +5463,7 @@ type A(i:int) =
| None -> failwith "declaration list is empty"

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``TryGetRecentCheckResultsForFile called with snapshot returns cached result after ParseAndCheckFile`` useTransparentCompiler =
let fileName1 = Path.ChangeExtension(tryCreateTemporaryFileName (), ".fs")
Expand Down Expand Up @@ -5538,7 +5538,7 @@ let ``#4030, Incremental builder creation warnings`` (args, errorSeverities) =
//------------------------------------------------------

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Unused opens in rec module smoke test 1`` useTransparentCompiler =

Expand Down Expand Up @@ -5613,7 +5613,7 @@ type UseTheThings(i:int) =
unusedOpensData |> shouldEqual expected

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Unused opens in non rec module smoke test 1`` useTransparentCompiler =

Expand Down Expand Up @@ -5688,7 +5688,7 @@ type UseTheThings(i:int) =
unusedOpensData |> shouldEqual expected

[<Test>]
[<TestCase true>]
// [<TestCase true>] // Flaky, reenable when stable
[<TestCase false>]
let ``Unused opens smoke test auto open`` useTransparentCompiler =

Expand Down Expand Up @@ -5861,4 +5861,4 @@ module internal EmptyProject =
let ``Empty source list produces error FS0207`` () =
let results = checker.ParseAndCheckProject(EmptyProject.options) |> Async.RunImmediate
results.Diagnostics.Length |> shouldEqual 1
results.Diagnostics[0].ErrorNumber |> shouldEqual 207
results.Diagnostics[0].ErrorNumber |> shouldEqual 207