Attempt to identify tests that potentially trip #16712 #16741
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, NodeCode will pass or flow threadstatics through thread switches by means of
wrapThreadStaticInfo.However, when we fall back to normal async, by e.g.
NodeCode.AwaitAsyncwe're on our own.Let's say there's an await that causes thread switch. Any global DiagnosticsLogger access after that will potentially target the wrong logger. This may be completely benign, or may cause some problems in other threads, see #16712.
This adds some instrumentation to look for such events in the CI. If this works correctly, every failed test here is potentially problematic.