Skip to content

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented Feb 21, 2024

So, NodeCode will pass or flow threadstatics through thread switches by means of wrapThreadStaticInfo.

However, when we fall back to normal async, by e.g. NodeCode.AwaitAsync we're on our own.
Let's say there's an await that causes thread switch. Any global DiagnosticsLogger access after that will potentially target the wrong logger. This may be completely benign, or may cause some problems in other threads, see #16712.

This adds some instrumentation to look for such events in the CI. If this works correctly, every failed test here is potentially problematic.

@github-actions
Copy link
Contributor

❗ Release notes required

@majocha,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.300.md No release notes found or release notes format is not correct

@majocha majocha closed this Feb 28, 2024
@majocha majocha deleted the asynclocal-compare-2 branch September 20, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant