Skip to content

Do not pass non-thread-safe logger to parallel computations in NodeCode.Parallel #16717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 16, 2024
Merged

Do not pass non-thread-safe logger to parallel computations in NodeCode.Parallel #16717

merged 4 commits into from
Feb 16, 2024

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented Feb 15, 2024 •
edited
Loading

See potential problem here: #16576 (comment)

The API could be better, but it works.

I think no release notes needed.

@majocha majocha requested a review from a team as a code owner February 15, 2024 14:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@0101 0101 added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Feb 15, 2024
psfinaki
psfinaki approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jakub!

@psfinaki psfinaki enabled auto-merge (squash) February 16, 2024 12:57
@psfinaki psfinaki merged commit 0f520bc into dotnet:main Feb 16, 2024
@dotnet-bot dotnet-bot mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@0101 0101 0101 approved these changes

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@majocha @0101 @psfinaki