Skip to content

Conversation

@baronfel
Copy link
Member

Description

A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change.

This causes the compile to be invoked in more scenarios where property that influence compilation change. See dotnet/sdk#16325 (comment) for full details on how this was found.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/releae-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

A companion to dotnet/msbuild#9743 to ensure that more sourcelink/determinism-related flags correctly cause the compiler to be invoked when they change
@baronfel baronfel requested a review from a team as a code owner February 14, 2024 21:50
@github-actions
Copy link
Contributor

✅ No release notes required

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, the companion PR got in, looks like without problems, merging this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants