- 
                Notifications
    You must be signed in to change notification settings 
- Fork 834
Add type providers support for the transparent compiler #16690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type providers support for the transparent compiler #16690
Conversation
| 
 | 
| That looks good! One thing to think about: so far we never actually had to manually invalidate any caches, rather everything is driven by constructing the appropriate key for each computation that describes what that computation depends on. I feel it makes reasoning about the whole thing a bit easier. It would be good if we could keep with it, however in this case it might be a bit tricky, so we can probably make an exception. Wonder if something could be doable inside  | 
| @0101 I'm really unsure how to write a proper test that would mimic the behaviour of an invalidating type-provider. This PR has already improved the situation. Could we revisit this maybe some other time? | 
…com/nojaf/fsharp into transparent-compiler-type-providers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this forward!
This may not be the ultimate solution but it should hopefully unblock most of basic type provider use cases. We can further improve it in the future.
* WIP * Clear all caches of projectSnapshot * Revert local test * Add todo about future plan.
Description
Hi @0101,
Trying to add support for type-provider to the transparent compiler.
This is a bit hard to explain so I made a quick recording:
fsharp-type-provider-trabsparent-compiler.mp4
Open questions are:
//cc @dawedawe
Fixes # (issue, if applicable)
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated: