Fix crash in DOTNET_SYSTEM_GLOBALIZATION_INVARIANT mode

[auduchinok]

Fixes #16272.

Applies the same fix as in dotnet/msbuild#8738 to prevent crashing when DOTNET_SYSTEM_GLOBALIZATION_INVARIANT is set.

[vzarytovskii]

Can this be auto-tested somehow?

[auduchinok]

Can this be auto-tested somehow?

Calling the fsc on Windows with DOTNET_SYSTEM_GLOBALIZATION_INVARIANT and non-ASCI locale should throw the exception from dotnet/msbuild#8738. I'm not sure what is the easiest way to add a test for it in the compiler repo. Could help me with that, please?

[vzarytovskii]

Can this be auto-tested somehow?

Calling the fsc on Windows with DOTNET_SYSTEM_GLOBALIZATION_INVARIANT and non-ASCI locale should throw the exception from dotnet/msbuild#8738. I'm not sure what is the easiest way to add a test for it in the compiler repo. Could help me with that, please?

Not entirely sure tbh. The only tests we invoke with FSC are F#QA. And we don't really want to add anything to the suite.

[T-Gro]

Can we get a standalone proof please?
Automatic test not needed in my opinion, just a proof of manual testing .

[github-actions]

❗ Release notes required

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/8.0.300.md

[auduchinok]

Can we get a standalone proof please?

Hm, I wasn't able to reproduce it myself. I'll ask @mfilippov (i.e. the author of the original MSBuild fix) later if there's a simple repro when he's back from vacation.

[mfilippov]

Yes, it is easy to reproduce. Just set locale for Unicode program different from US.

[0101]

@auduchinok were you able to confirm the fix works using the repro steps?

[auduchinok]

AFAIK it helps, yes.

[psfinaki]

@auduchinok please move the release notes to the next version 👀