Service: wrap creating reference from module reader into cancellable #16338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auduchinok
force-pushed
the
cancellable-reader2
branch
from
d46b55a to
96ad486
Compare
psfinaki
approved these changes
Nov 24, 2023
T-Gro
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the initial processing of
FSharpReferencedProject.ILModuleReferencewasn't wrapped intocancellable, making it non-cancellable viaCancellable.CheckAndThrow. The similar code processingFSharpReferencedProject.PEReferencewas already wrapped correctly, so it's onlyILModuleReferencethat had this issue. The fix usescancellablecomputation instead of plainnode.