Skip to content

Incremental builder: fix exception when source files list is empty #16314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 21, 2023
Merged

Incremental builder: fix exception when source files list is empty #16314

merged 2 commits into from
Nov 21, 2023

Conversation

@majocha
Copy link
Contributor

@majocha majocha commented Nov 21, 2023 •
edited
Loading

Fixes #16312
In case of empty file list FS0207: "No inputs specified" is returned. I added a test for this.

@majocha majocha marked this pull request as ready for review November 21, 2023 09:25
@majocha majocha requested a review from a team as a code owner November 21, 2023 09:25
@majocha
Copy link
Contributor Author

majocha commented Nov 21, 2023

One error that looks unrelated:

error FS2014: A problem occurred writing the binary 'D:\a_work\1\s\tests\fsharp\core\large\matches\test.exe': Could not open file for writing (binary mode): D:\a_work\1\s\tests\fsharp\core\large\matches\test.exe

@vzarytovskii vzarytovskii enabled auto-merge (squash) November 21, 2023 16:37
@vzarytovskii vzarytovskii merged commit e531233 into dotnet:main Nov 21, 2023
@majocha majocha deleted the fix-empty-builder branch November 21, 2023 19:08
@allisonchou allisonchou mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exception at IncrementalBuild.fs Line 813: The input array was empty. (Parameter 'array')

3 participants

@majocha @0101 @vzarytovskii