Skip to content

Respect line limit in QuickInfo #16208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Respect line limit in QuickInfo #16208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fc1fd7
respect line limit in quick info
majocha Oct 31, 2023
527624c
Merge branch 'main' into fix-line-limit
majocha Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions vsintegration/src/FSharp.Editor/DocComments/XMLDocumentation.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,12 @@ type internal TextSanitizingCollector(collector, ?lineLimit: int) =

interface ITaggedTextCollector with
member _.Add taggedText =
// TODO: bail out early if line limit is already hit
match taggedText.Tag with
| TextTag.Text -> reportTextLines taggedText.Text
| _ -> addTaggedTextEntry taggedText
match lineLimit with
| Some lineLimit when lineLimit < count -> ()
| _ ->
match taggedText.Tag with
| TextTag.Text -> reportTextLines taggedText.Text
| _ -> addTaggedTextEntry taggedText

member _.IsEmpty = isEmpty
member _.EndsWithLineBreak = isEmpty || endsWithLineBreak
Expand Down