Making code fixes generate multiple suggestions again #16004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
T-Gro
approved these changes
Sep 19, 2023
abonie
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15890
I think this is the last addition to the code fix framework. A few code fixes can generate multiple suggestions, so here I add a notion of this. Technically we could generalize the existing interface (
IFSharpCodeFixProvider), but I decided to create another one - to keep the intention clear and to not complicate the code for the majority of code fixes which do not need this.Note, this used to work, but got broken here when we changed the equivalence key - it used to be the code fix message (different for suggestions) to the code fix name (same for suggestions). In fact, we don't need any equivalence key now - we don't have equivalent code fixes yet.
Demo:
multifix.mp4