Skip to content

Parser: report error on missing first item in tuple expressions #15999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Parser: report error on missing first item in tuple expressions #15999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58b8fdb
Parser: report error on missing first item in tuple expressions
auduchinok Sep 19, 2023
ca2999f
Merge branch 'main' into parser-expr-tupleComma
vzarytovskii Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Compiler/pars.fsy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5173,6 +5173,7 @@ parenExpr:
{ let mComma = rhs parseState 2
let mLparen = rhs parseState 1
let mRparen = rhs parseState 3
reportParseErrorAt mComma (FSComp.SR.parsExpectingExpression ())
let errorExpr = arbExpr ("tupleExpr3", mComma.EndRange)
let mTuple = unionRanges mComma $3.Range
let tupleExpr =
Expand Down
2 changes: 2 additions & 0 deletions tests/service/data/SyntaxTree/Expression/Tuple - Missing item 02.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ ImplFile
(1,0--3,4), { LeadingKeyword = Module (1,0--1,6) })], (true, true),
{ ConditionalDirectives = []
CodeComments = [] }, set []))

(3,1)-(3,2) parse error Expecting expression
2 changes: 2 additions & 0 deletions tests/service/data/SyntaxTree/Expression/Tuple - Missing item 03.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ ImplFile
(1,0--3,6), { LeadingKeyword = Module (1,0--1,6) })], (true, true),
{ ConditionalDirectives = []
CodeComments = [] }, set []))

(3,1)-(3,2) parse error Expecting expression