Skip to content

Fix a bug in a code fix #15973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix a bug in a code fix #15973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion vsintegration/src/FSharp.Editor/CodeFixes/UseMutationWhenValueIsMutable.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ type internal UseMutationWhenValueIsMutableCodeFixProvider [<ImportingConstructo

let adjustedPosition =
let rec loop ch pos =
if Char.IsWhiteSpace(ch) then
if
Char.IsWhiteSpace(ch)
// edge case - end of file
|| pos = sourceText.Length - 1
then
pos
else
loop sourceText[pos + 1] (pos + 1)
Expand Down
13 changes: 7 additions & 6 deletions vsintegration/tests/FSharp.Editor.Tests/CodeFixes/UseMutationWhenValueIsMutableTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,15 @@ let f x =

Assert.Equal(expected, actual)

[<Fact>]
let ``Doesn't fix unrelated FS0020`` () =
let code =
"""
[<Theory>]
[<InlineData """
let square x = x * x
square 32
"""

""">]
[<InlineData """
let band = {| Name = "R.E.M." |}
band""">]
let ``Doesn't fix unrelated FS0020`` code =
let expected = None

let actual = codeFix |> tryFix code Auto
Expand Down