Skip to content

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Sep 8, 2023

Adds parser recovery for unfinished head patterns in members. pathOp rule inside the pattern didn't recover properly and subsequent code couldn't be parsed too.

type T =
    member this.

()
{ new T with
      member this. }

()

It also adds tests for object expressions.

@auduchinok auduchinok requested a review from a team as a code owner September 8, 2023 11:45
@auduchinok auduchinok changed the title Parser: recover on unfinished self pat in members Parser: recover on unfinished head pat in members Sep 8, 2023
@auduchinok
Copy link
Member Author

This is also ready. 🙂

Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@T-Gro T-Gro merged commit 7f791ed into dotnet:main Sep 12, 2023
@auduchinok auduchinok deleted the parser-member-thisDot branch September 18, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants