Skip to content

Parser: recover on unfinished record patterns #15921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 5, 2023
Merged

Parser: recover on unfinished record patterns #15921

merged 2 commits into from
Sep 5, 2023

Conversation

@auduchinok
Copy link
Member

@auduchinok auduchinok commented Sep 4, 2023

As discussed in #15903, adds recovery for the following cases:

match () with
| { } -> ()
match () with
| { F } -> ()
match () with
| { F = } -> ()

@auduchinok auduchinok requested a review from a team as a code owner September 4, 2023 11:24
psfinaki
psfinaki approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beatiful

@psfinaki psfinaki mentioned this pull request Sep 4, 2023
Merged
@T-Gro T-Gro merged commit f496b3c into dotnet:main Sep 5, 2023
@allisonchou allisonchou mentioned this pull request Sep 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

+2 more reviewers

@psfinaki psfinaki psfinaki approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@auduchinok @psfinaki @edgarfgp @T-Gro