Skip to content

Add a Paren case to SynRationalConst #15885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 28, 2023
Merged

Add a Paren case to SynRationalConst #15885

merged 3 commits into from
Aug 28, 2023

Conversation

@dawedawe
Copy link
Contributor

@dawedawe dawedawe commented Aug 28, 2023

To help tooling this adds

  • a Paren case to SynRationalConst, analogous to SynMeasure.Paren, to capture the full range with the parens included.
  • another range field to SynRationalConst.Rational to capture the range of the / operator

@dawedawe dawedawe requested a review from a team as a code owner August 28, 2023 14:07
nojaf
nojaf reviewed Aug 28, 2023
View reviewed changes
@KevinRansom KevinRansom merged commit 97a5b65 into dotnet:main Aug 28, 2023
@dawedawe dawedawe deleted the rational_ranges branch August 29, 2023 06:34
@allisonchou allisonchou mentioned this pull request Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonie abonie abonie approved these changes

+2 more reviewers

@nojaf nojaf nojaf left review comments

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dawedawe @nojaf @KevinRansom @abonie