-
Notifications
You must be signed in to change notification settings - Fork 833
Fix regression for FS0725 #15874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression for FS0725 #15874
Conversation
|
On a second look while working on this fix. I think for match None with
| None x -> () // In F#8 this shows Warning FS3548 instead of Error FS0725 ? I think is should as it was in F#7
type C = | C
let myDiscardedArgFunc2(C c) = () // In F#8 this shows Warning FS3548 instead of Error FS0725 ? I think is should be as it was in F#7Any thoughts? cc @vzarytovskii |
Yeah, I guess we shouldn't downgrade error to warning here. |
Also the FS3548 error message does not really match what is happening here Update: FS3548 imo is really about discard |
|
This is ready |
As discovered by failing test on
FsAutoCompletein F# 8 we no longer showFS0725in cases where it is supposed to.PR that introduced the regression #14055