Skip to content

Don't suppress inline keyword in GetValSignatureText. #15827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Don't suppress inline keyword in GetValSignatureText. #15827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Compiler/Symbols/Symbols.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2357,7 +2357,7 @@ type FSharpMemberOrFunctionOrValue(cenv, d:FSharpMemberOrValData, item) =

member x.GetValSignatureText (displayContext: FSharpDisplayContext, m: range) =
checkIsResolved()
let displayEnv = { displayContext.Contents cenv.g with includeStaticParametersInTypeNames = true }
let displayEnv = { displayContext.Contents cenv.g with includeStaticParametersInTypeNames = true; suppressInlineKeyword = false }

let stringValOfMethInfo (methInfo: MethInfo) =
match methInfo with
Expand Down
16 changes: 15 additions & 1 deletion tests/service/Symbols.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,7 +752,21 @@ type Foo() =
and set (a: int) (b: float) = ()
"""
(5, 14, " member _.X", "X")


[<Test>]
let ``Signature text for inline property`` () =
assertSignature
"member inline Item: i: int * j: char -> string with get\nmember inline Item: i: int * j: char -> string with set"
"""
module Meh

type Foo =
member inline this.Item
with get (i:int,j: char) : string = ""
and set (i:int,j: char) (x:string) = printfn "%i %c" i j
"""
(5, 27, " member inline this.Item", "Item")

module AnonymousRecord =
[<Test>]
let ``Anonymous record copy-and-update symbols usage`` () =
Expand Down